Re: [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret'

From: Bjorn Andersson
Date: Tue Jan 26 2021 - 09:03:26 EST


On Tue 26 Jan 06:45 CST 2021, Lee Jones wrote:

> Fixes the following W=1 kernel build warning(s):
>
> drivers/clk/qcom/gcc-ipq4019.c: In function ‘clk_cpu_div_set_rate’:
> drivers/clk/qcom/gcc-ipq4019.c:1279:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>
> Cc: Andy Gross <agross@xxxxxxxxxx>
> Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> Cc: Michael Turquette <mturquette@xxxxxxxxxxxx>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxx>
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> Cc: linux-clk@xxxxxxxxxxxxxxx

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> drivers/clk/qcom/gcc-ipq4019.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq4019.c b/drivers/clk/qcom/gcc-ipq4019.c
> index ef5137fd50f3f..8abad4032de71 100644
> --- a/drivers/clk/qcom/gcc-ipq4019.c
> +++ b/drivers/clk/qcom/gcc-ipq4019.c
> @@ -1276,16 +1276,15 @@ static int clk_cpu_div_set_rate(struct clk_hw *hw, unsigned long rate,
> struct clk_fepll *pll = to_clk_fepll(hw);
> const struct freq_tbl *f;
> u32 mask;
> - int ret;
>
> f = qcom_find_freq(pll->freq_tbl, rate);
> if (!f)
> return -EINVAL;
>
> mask = (BIT(pll->cdiv.width) - 1) << pll->cdiv.shift;
> - ret = regmap_update_bits(pll->cdiv.clkr.regmap,
> - pll->cdiv.reg, mask,
> - f->pre_div << pll->cdiv.shift);
> + regmap_update_bits(pll->cdiv.clkr.regmap,
> + pll->cdiv.reg, mask,
> + f->pre_div << pll->cdiv.shift);
> /*
> * There is no status bit which can be checked for successful CPU
> * divider update operation so using delay for the same.
> --
> 2.25.1
>