Re: [PATCH 21/21] clk: zynqmp: divider: Add missing description for 'max_div'

[Michal Simek]

On 1/26/21 1:45 PM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/clk/zynqmp/divider.c:46: warning: Function parameter or member 'max_div' not described in 'zynqmp_clk_divider'
> 
> Cc: Michael Turquette <mturquette@xxxxxxxxxxxx>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxx>
> Cc: Michal Simek <michal.simek@xxxxxxxxxx>
> Cc: Rajan Vaja <rajan.vaja@xxxxxxxxxx>
> Cc: linux-clk@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
>  drivers/clk/zynqmp/divider.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c
> index 66da02b83d393..e9bf7958b8218 100644
> --- a/drivers/clk/zynqmp/divider.c
> +++ b/drivers/clk/zynqmp/divider.c
> @@ -35,6 +35,7 @@
>   * @is_frac:	The divider is a fractional divider
>   * @clk_id:	Id of clock
>   * @div_type:	divisor type (TYPE_DIV1 or TYPE_DIV2)
> + * @max_div:	maximum supported divisor (fetched from firmware)
>   */
>  struct zynqmp_clk_divider {
>  	struct clk_hw hw;
> 

In our soc tree we have
 * @max_div:    Maximum divisor value allowed

But your description should be also fine. Rajan please reply if I am
wrong. Otherwise:
Acked-by: Michal Simek <michal.simek@xxxxxxxxxx>

Thanks,
Michal