Re: [PATCHv3 1/6] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag

[Richard Gong]

Hi Tom,

On 1/25/21 4:56 PM, Tom Rix wrote:
> On 1/25/21 12:56 PM, richard.gong@xxxxxxxxxxxxxxx wrote:
> > From: Richard Gong <richard.gong@xxxxxxxxx>
> >
> > Add COMMAND_AUTHENTICATE_BITSTREAM command flag for new added bitstream
> > authentication feature. Authenticating a bitstream is to make sure a signed
> > bitstream has the valid signatures.
> >
> > Except for the actual configuration of the device, the bitstream
> > authentication works the same way as FPGA configuration does. If the
> > authentication passes, the signed bitstream will be programmed into QSPI
> > flash memory and will be expected to boot without issues.
> >
> > Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which
> > aligns with the firmware settings.
> >
> > Signed-off-by: Richard Gong <richard.gong@xxxxxxxxx>
> > ---
> > v3: no change
> > v2: new added
> > ---
> >   include/linux/firmware/intel/stratix10-svc-client.h | 11 ++++++++---
> >   1 file changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h
> > index ebc2956..7ada1f2 100644
> > --- a/include/linux/firmware/intel/stratix10-svc-client.h
> > +++ b/include/linux/firmware/intel/stratix10-svc-client.h
> > @@ -51,12 +51,17 @@
> >   #define SVC_STATUS_NO_SUPPORT		6
> >   
> >   /*
>
> This patch fails to apply, i believe the conflict is because in mainline this is '/**' not '/*'
>
> Please check or point me at the branch/tag you are using.

I am using next-20210125 tag.

> I am using char-misc-next.
>
> Tom
>
> Tom
Regards,
Richard