Re: [PATCH v3] soc/tegra: Add devm_tegra_core_dev_init_opp_table()

[Dmitry Osipenko]

25.01.2021 06:07, Viresh Kumar пишет:
> On 22-01-21, 17:41, Dmitry Osipenko wrote:
>> 22.01.2021 09:35, Viresh Kumar пишет:
>>> On 21-01-21, 22:01, Dmitry Osipenko wrote:
>>>> Add common helper which initializes OPP table for Tegra SoC core devices.
>>>>
>>>> Tested-by: Peter Geis <pgwipeout@xxxxxxxxx> # Ouya T30
>>>> Tested-by: Dmitry Osipenko <digetx@xxxxxxxxx> # A500 T20 and Nexus7 T30
>>>> Tested-by: Nicolas Chauvet <kwizart@xxxxxxxxx> # PAZ00 T20 and TK1 T124
>>>> Tested-by: Matt Merhar <mattmerhar@xxxxxxxxxxxxxx> # Ouya T30
>>>> [tested on some other non-upstreamed-yet T20/30/114 devices as well]
>>>> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
>>>> ---
>>>>
>>>> Changelog:
>>>>
>>>> v3: - This patch is factored out from [1] to ease merging of the patches
>>>>       that will use the new helper. The goal is to get this new helper
>>>>       into 5.12, this should remove dependency on this patch for a several
>>>>       patchsets of a different subsystems (DRM, media, memory, etc) that
>>>>       will target 5.13.
>>>>
>>>>       @Thierry/Jon, please review and apply this patch for 5.12!
>>>
>>> This is not how stuff works in kernel Dmitry, every commit in the
>>> kernel tree should build(at least)/boot fine. Your patch can only be
>>> applied once your base tree has all the patches on which your work is
>>> based of, otherwise this will lead to build failure (stuff like git
>>> bisect breaks with that). It would be better if you take this patch in
>>> 5.13, or after 5.12-rc2 once all other stuff lands.
>>>
>>
>> OMG, I completely missed that the devm series from Yangtao Li isn't
>> merged yet.
>>
>> Viresh / Yangtao, will be it be okay if I'll collect all the
>> prerequisite devm patches from Yangtao + add this patch into a single
>> series that could be merged via the OPP tree for 5.12?
>>
>> Of course Thierry or Jon will need to give the ack for the Tegra changes
>> in that case.
> 
> I haven't heard back from Yangtao since his last post, not sure what's going on.
> It is normally better if he keeps posting his series, unless he is busy and will
> not be able to do it.
> 

Indeed, it will be much better if Yangtao could make the update, no
doubt about this.

If devm_tegra_core_dev_init_opp_table() will miss 5.12, then it will
likely put on hold couple Tegra patches for a another 2+ months, which
isn't critical, but it's a bit difficult to accept morally :)

Yangtao, could you please let us know the current status of yours
series? If you don't have spare time right now to finish v2, then I'd
like to pick up couple patches from yours v1 which add the devm_*
helpers that are used by this patch to make a small patchset that could
go into 5.12.