Re: [PATCH 3/3] arm64: dts: qcom: msm8916-longcheer-l8910: Add imu/magnetometer

[Jonathan Albrieux]

On Sun, Jan 24, 2021 at 04:51:31PM +0100, Stephan Gerhold wrote:
> On Sun, Jan 24, 2021 at 04:07:19PM +0100, Konrad Dybcio wrote:
> > > +&blsp_i2c3 {
> > > +	status = "okay";
> > > +
> > > +	imu@68 {
> > > +		compatible = "bosch,bmi160";
> > > +		reg = <0x68>;
> > > +
> > > +		vdd-supply = <&pm8916_l17>;
> > > +		vddio-supply = <&pm8916_l6>;
> > > +
> > > +		mount-matrix = "0", "1", "0",
> > > +			      "-1", "0", "0",
> > > +			       "0", "0", "1";
> > > +	};
> > > +
> > > +	magnetometer@d {
> > > +		compatible = "asahi-kasei,ak09911";
> > > +		reg = <0x0d>;
> > > +
> > > +		vdd-supply = <&pm8916_l17>;
> > > +		vid-supply = <&pm8916_l6>;
> > > +
> > > +		reset-gpios = <&msmgpio 111 GPIO_ACTIVE_LOW>;
> > > +
> > > +		pinctrl-names = "default";
> > > +		pinctrl-0 = <&mag_reset_default>;
> > > +	};
> > > +};
> > 
> > Please sort I2C devices by their address.
> > 
> 
> +1 :)
> 
Thank you Konrad, thank you Stephan, I'll fix the order!

> > 
> > >  	};
> > >  
> > > +	mag_reset_default: mag-reset-default {
> > > +		pins = "gpio111";
> > > +		function = "gpio";
> > > +
> > > +		drive-strength = <2>;
> > > +		bias-disable;
> > > +	};
> > > +
> > 
> > Please add this after gpio110 to keep it sorted gpio-number-wise.
> > 
> 
> This is ordered alphabetically. I haven't seen gpio-number order
> anywhere yet... :)
> 
Let me know if this order has to be changed, meanwhile I'll prepare
a v2 for the i2c device order and will prepare a v3 in case this
order too has to be changed.

Again, thank you,
Jonathan

> Thanks,
> Stephan