Re: [PATCH] bus: qcom: Put child node before return

From: Linus Walleij
Date: Fri Jan 22 2021 - 17:50:23 EST


On Thu, Jan 21, 2021 at 12:49 PM Pan Bian <bianpan2016@xxxxxxx> wrote:

> Put child node before return to fix potential reference count leak.
> Generally, the reference count of child is incremented and decremented
> automatically in the macro for_each_available_child_of_node() and should
> be decremented manually if the loop is broken in loop body.
>
> Fixes: 335a12754808 ("bus: qcom: add EBI2 driver")
> Signed-off-by: Pan Bian <bianpan2016@xxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Please submit this patch for inclusion through the ARM SoC tree.

Yours,
Linus Walleij