Re: [PATCH v4] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default

[Saravana Kannan]

On Fri, Jan 22, 2021 at 5:08 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Fri, Jan 22, 2021 at 10:55 AM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:

Andy, I'll address your exit() comments too.

> > On Fri, Jan 22, 2021 at 12:40 AM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
>
> > > @@ -596,6 +596,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
> > >                 gdev->dev.of_node = gc->of_node;
> > >         else
> > >                 gc->of_node = gdev->dev.of_node;
> > > +       gdev->dev.fwnode = of_fwnode_handle(gdev->dev.of_node);
> >
> > This looks like a complete breakage on ACPI enabled systems.
>
> This looks broken to me too, if OF functions are compiled out
> this happens:
>
> include/linux/of.h:#define of_fwnode_handle(node) NULL
>
> And if there is a valid fwnode in the device it gets overwritten
> with NULL.
>
> This is partly why I want the DT code to be in its own file.

Yeah, both of you are right that this is broken.

So all I really need to do to fix this is:
if (gdev->dev.of_node)
    gdev->dev.fwnode = of_fwnode_handle(gdev->dev.of_node);

I don't mind putting this in gpiolib-of.c. It's just kinda weird to me
to call into gpiolib-of.c just for these 2 lines.

I'll just move the entire block inside #ifdef into gpiolib-of.c in the
next version. Let me know how it looks.

-Saravana