Re: [PATCH] cpupower: add Makefile dependencies for install targets

From: Shuah Khan
Date: Fri Jan 22 2021 - 13:07:08 EST


On 1/7/21 2:29 PM, Thomas Renninger wrote:
Am Donnerstag, 7. Januar 2021, 22:15:16 CET schrieb Ivan Babrou:
On Thu, Jan 7, 2021 at 12:59 PM Thomas Renninger <trenn@xxxxxxxx> wrote:
Am Donnerstag, 7. Januar 2021, 18:42:25 CET schrieb Ivan Babrou:
On Thu, Jan 7, 2021 at 2:07 AM Thomas Renninger <trenn@xxxxxxxx> wrote:
Am Dienstag, 5. Januar 2021, 00:57:18 CET schrieb Ivan Babrou:
This allows building cpupower in parallel rather than serially.
...
Can you please show the make calls, ideally with a timing to better
understand and also to reproduce the advantages this patch introduces.
From what I can see, it only helps if one calls "sub-install" targets
directly?

That's exactly what we do: make install directly:

/linux-5.10.5$ make -C ./tools/power/cpupower DESTDIR=/tmp/cpupower
install -j $(nproc)

This makes sense then.
@Shuah @Rafael: Can this patch be queued up, please.

Thanks for the patch and the details,


Thank you both.

I applied it https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/commit/?h=cpupower

Will send this in my next pull request to Rafael.

thanks,
-- Shuah