Re: [PATCH] mm: Optimizing error condition detection in do_mprotect_pkey()

[Jarkko Sakkinen]

On Thu, Jan 21, 2021 at 02:46:27PM -0800, Andrew Morton wrote:
> On Wed, 20 Jan 2021 16:29:20 +0200 Jarkko Sakkinen <jarkko@xxxxxxxxxx> wrote:
> 
> > 
> > 
> > On Mon, Jan 18, 2021 at 09:33:10PM +0800, Tianjia Zhang wrote:
> > > Obviously, the error variable detection of the if statement is
> > > for the mprotect callback function, so it is also put into the
> > > scope of calling callbck.
> > > 
> > > Reported-by: Jia Zhang <zhang.jia@xxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>
> > 
> > No fixes tag, no description what this commit does. Nothing
> > makes sense to me.
> 
> It's a little cleanup.  Makes the flow at this site consistent with the
> other places where this function handles errors.  I added a bit to the
> changelog mentioning this.

Alright, I see. I'm just used to getting feedback to my own patches
that "imperative form" of expression should be rigidly used. That's the
main reason I gave the feedback.

/Jarkko