RE: [EXTERNAL] Re: [PATCH net 0/1] net: phy: Fix interrupt mask loss on resume from hibernation

[Badel, Laurent]

> From: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> Sent: Friday, January 22, 2021 4:20 PM

> The (optional) software reset is done via soft_reset callback.
> So if the PHY in question needs special treatment after a soft reset,
> why not add it to the soft_reset callback?

Thank you very much for the fast reply. This makes sense, I will 
modify the patch in this direction. 
 
> This sounds to me like a lower level driver (e.g. for GPIO / interrupt
> controller) not resuming properly from hibernation. Supposedly things
> like edge/level high/low/both are stored per interrupt line in a
> register of the interrupt controller, and the controller would have to
> restore the register value on resume from hibernation. You may want to
> have a look at that driver.

I think you are right, the gpio-mxs driver has no PM operations, so 
if it responsible for restoring the interrupt level, no wonder it 
doesn't. This would require implementing the PM ops, which would 
take some additional work, I'll see if I can get around to doing this.
 
Best regards,

Laurent



-----------------------------
Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de la Longeraie 7, 1110, Morges, Switzerland 

-----------------------------