Re: [PATCH] PNP: add printf attribute to log function

From: Rafael J. Wysocki
Date: Fri Jan 22 2021 - 10:23:48 EST


On Mon, Dec 21, 2020 at 5:04 PM <trix@xxxxxxxxxx> wrote:
>
> From: Tom Rix <trix@xxxxxxxxxx>
>
> Attributing the function allows the compiler to more thoroughly
> check the use of the function with -Wformat and similar flags.
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
> drivers/pnp/interface.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pnp/interface.c b/drivers/pnp/interface.c
> index 187e4a1175b0..602c46893e83 100644
> --- a/drivers/pnp/interface.c
> +++ b/drivers/pnp/interface.c
> @@ -33,6 +33,7 @@ struct pnp_info_buffer {
>
> typedef struct pnp_info_buffer pnp_info_buffer_t;
>
> +__printf(2, 3)
> static int pnp_printf(pnp_info_buffer_t * buffer, char *fmt, ...)
> {
> va_list args;
> --

Applied as 5.12 material, thanks!