Re: [PATCH v5 6/6] kasan: Forbid kunit tests when async mode is enabled

From: Vincenzo Frascino
Date: Fri Jan 22 2021 - 06:27:31 EST



On 1/21/21 5:40 PM, Andrey Konovalov wrote:
>> diff --git a/lib/test_kasan.c b/lib/test_kasan.c
>> index 7285dcf9fcc1..1306f707b4fe 100644
>> --- a/lib/test_kasan.c
>> +++ b/lib/test_kasan.c
>> @@ -52,6 +52,11 @@ static int kasan_test_init(struct kunit *test)
>> return -1;
>> }
>>
>> + if (!hw_is_mode_sync()) {
>> + kunit_err(test, "can't run KASAN tests in async mode");
>> + return -1;
>> + }
> I'd rather implement this check at the KASAN level, than in arm64
> code. Just the way kasan_stack_collection_enabled() is implemented.
>
> Feel free to drop this change and the previous patch, I'll implement
> this myself later.
>

Fine by me, will drop 5 and 6 in v5.

--
Regards,
Vincenzo