Re: [PATCH -next] hid/hid-sensor-custom: convert comma to semicolon

From: Jonathan Cameron
Date: Fri Jan 22 2021 - 03:55:56 EST


On Wed, 20 Jan 2021 20:49:57 +0000
Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Tue, 29 Dec 2020 18:18:41 +0000
> Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> > On Mon, 14 Dec 2020 06:13:58 -0800
> > Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> wrote:
> >
> > > On Mon, 2020-12-14 at 21:32 +0800, Zheng Yongjun wrote:
> > > > Replace a comma between expression statements by a semicolon.
> > > >
> > > > Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>
> > > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > Applied to the togreg branch of iio.git and pushed out as testing for
> > the autobuilders to see if they can break it.
> Hi Jiri,
>
> Just realised this is in HID rather than IIO. I hope you don't mind as
> it's now deep in a tree I'd rather not rebase.

On basis it wasn't actually that bad, (only one merge after it) I did
the rebase and dropped this patch. Jiri, guess you probably
want to pick this up through HID.

Thanks,

Jonathan

>
> Sorry about that.
>
> Jonathan
>
> >
> > Thanks,
> >
> > Jonathan
> >
> > >
> > > > ---
> > > >  drivers/hid/hid-sensor-custom.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> > > > sensor-custom.c
> > > > index 4d25577a8573..6c47a2e7623d 100644
> > > > --- a/drivers/hid/hid-sensor-custom.c
> > > > +++ b/drivers/hid/hid-sensor-custom.c
> > > > @@ -728,7 +728,7 @@ static int hid_sensor_custom_dev_if_add(struct
> > > > hid_sensor_custom *sensor_inst)
> > > >  
> > > >         sensor_inst->custom_dev.minor = MISC_DYNAMIC_MINOR;
> > > >         sensor_inst->custom_dev.name = dev_name(&sensor_inst->pdev-
> > > > >dev);
> > > > -       sensor_inst->custom_dev.fops = &hid_sensor_custom_fops,
> > > > +       sensor_inst->custom_dev.fops = &hid_sensor_custom_fops;
> > > >         ret = misc_register(&sensor_inst->custom_dev);
> > > >         if (ret) {
> > > >                 kfifo_free(&sensor_inst->data_fifo);
> > >
> > >
> >
>