RE: [PATCH v2 3/3] perf vendor events: Add Fujitsu A64FX V1.2 pmu event

From: nakamura.shun@xxxxxxxxxxx
Date: Fri Jan 22 2021 - 03:49:06 EST


Hi John

> I think that we need to the same here as the IMPDEF recommended events - add a
> common JSON to reduce the duplication.
>
> I had done work on this for current CPUs, but never got it finished. Let me check
> the status.

If you let me know the result, I will resend the patch according to the policy.

Best Regards

> -----Original Message-----
> From: John Garry <john.garry@xxxxxxxxxx>
> Sent: Friday, January 22, 2021 2:41 AM
> To: Nakamura, Shunsuke/中村 俊介 <nakamura.shun@xxxxxxxxxxx>
> Cc: will@xxxxxxxxxx; mathieu.poirier@xxxxxxxxxx; leo.yan@xxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 3/3] perf vendor events: Add Fujitsu A64FX V1.2 pmu
> event
>
> On 21/01/2021 10:54, Shunsuke Nakamura wrote:
> > + {
> > + "PublicDescription": "This event counts each correction to the predicted
> program flow that occurs because of a misprediction from, or no prediction from,
> the branch prediction resources and that relates to instructions that the branch
> prediction resources are capable of predicting.",
> > + "EventCode": "0x10",
> > + "EventName": "BR_MIS_PRED",
>
> I think that we need to the same here as the IMPDEF recommended events - add a
> common JSON to reduce the duplication.
>
> I had done work on this for current CPUs, but never got it finished. Let me check
> the status.
>
> Cheers,
> John
>
> Ps, arm have put JSONs here for their cores:
>
> https://github.com/ARM-software/data/tree/master/pmu
>
> But unfortunately the schema does not suit perf.
>
> I raised an issue, but no response.
>
> I'm just wondering if you hand copied the JSON data.
>
>
> > + "BriefDescription": "This event counts each correction to the predicted
> program flow that occurs because of a misprediction from, or no prediction from,
> the branch prediction resources and that relates to instructions that the branch
> prediction resources are capable of predicting."
> > + },