Re: [PATCH] perf metricgroup: Fix system PMU metrics

[Arnaldo Carvalho de Melo]

Em Wed, Jan 20, 2021 at 09:15:54AM +0000, John Garry escreveu:
> On 20/01/2021 05:15, Joakim Zhang wrote:
> > For this patch: Tested-by: Joakim Zhang <qiangqing.zhang@xxxxxxx>

> > Hi John, Jolsa,

> > Is there any way to avoid breaking exist metric expressions? If not, it will always happened after metricgroup changes.
 
> They are not normally broken like that. Normally we test beforehand, but
> these cases were missed here by me. However if you were testing them
> previously, then it would be expected that you had tested them again for the
> final patchset which was merged.
 
> Anyway, we can look to add metric tests for these.
 
> @Arnaldo, I will send separate formal patch for this today.

Hi John, can you please take a look at my tmp.perf/urgent branch and see
if all is well, i.e. the versions of these patches are the ones that
should be merged and that all the patches discussed are there?

For your convenience:

https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=tmp.perf/urgent

Thanks,

- Arnaldo