Re: [PATCH] soundwire: debugfs: use controller id instead of link_id

From: Pierre-Louis Bossart
Date: Thu Jan 21 2021 - 13:51:02 EST




diff --git a/drivers/soundwire/debugfs.c b/drivers/soundwire/debugfs.c
index b6cad0d59b7b..f22868614f09 100644
--- a/drivers/soundwire/debugfs.c
+++ b/drivers/soundwire/debugfs.c
@@ -19,13 +19,14 @@ void sdw_bus_debugfs_init(struct sdw_bus *bus)
                return;

        /* create the debugfs master-N */
+       bus->controller_debugfs = debugfs_create_dir(dev_name(bus->dev), sdw_debugfs_root);

bus->dev = &md->dev;

dev_name(bus->dev) does not describe a controller at all but an individual master.

We might as well just change the information as:

snprintf(name, sizeof(name), "master-%d-%d", bus_id, bus->link_id);

you get the system unique ID and controller-relative ID, and you can decide to ignore one or the other on different platform.