Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

From: Hector Martin 'marcan'
Date: Thu Jan 21 2021 - 11:55:03 EST


On 20/01/2021 22.27, Mohamed Mediouni wrote:
+ irq_domain_set_info(d, virq, hw, &apple_aic_irq_chip,
+ d->host_data, handle_level_irq, NULL, NULL);

The AIC automatically masks IRQs on reason fetch, which means the handle_level_irq flow is redundant. Using the fasteoi flow, as in [1], should be more efficient.

[1] https://github.com/AsahiLinux/linux/commit/d4cb18c93

--
Hector Martin "marcan" (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub