Re: [PATCH 4/5] watchdog: remove tango driver

From: Guenter Roeck
Date: Thu Jan 21 2021 - 11:35:32 EST


On 1/21/21 7:18 AM, Arnd Bergmann wrote:
> On Thu, Jan 21, 2021 at 3:01 PM Måns Rullgård <mans@xxxxxxxxx> wrote:
>> Arnd Bergmann <arnd@xxxxxxxxxx> writes:
>>> From: Arnd Bergmann <arnd@xxxxxxxx>
>>>
>>> The tango platform is getting removed, so the driver is no
>>> longer needed.
>>>
>>> Cc: Marc Gonzalez <marc.w.gonzalez@xxxxxxx>
>>> Cc: Mans Rullgard <mans@xxxxxxxxx>
>>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>>> ---
>>> drivers/watchdog/Kconfig | 11 --
>>> drivers/watchdog/Makefile | 1 -
>>> drivers/watchdog/tangox_wdt.c | 209 ----------------------------------
>>> 3 files changed, 221 deletions(-)
>>> delete mode 100644 drivers/watchdog/tangox_wdt.c
>>
>> The DT binding can go as well.
>
> Good catch! I thought I had cross-checked all DT compatible strings of the
> removed dts files, bindings and drivers to make sure everything is gone
> at once, but it seems I missed a couple of files including this one.
>
> Guenter and Wim, let me know if I should resend this patch or all watchdog
> patches, or just remove the binding as part of the platform removal in the
> soc tree.

I'd suggest to just resend this patch, or to send another one on top of it.
It is Wim's call to make, though, since he will apply the patches.

Guenter