Re: [PATCH v2 1/4] KVM: x86: Factor out x86 instruction emulation with decoding

From: Paolo Bonzini
Date: Thu Jan 21 2021 - 09:26:25 EST


On 21/01/21 15:04, Maxim Levitsky wrote:
+int x86_emulate_decoded_instruction(struct kvm_vcpu *vcpu, int emulation_type,
+ void *insn, int insn_len)
Isn't the name of this function wrong? This function decodes the instruction.
So I would expect something like x86_decode_instruction.


Yes, that or x86_decode_emulated_instruction.

Paolo