Re: [PATCH v2 2/2] interconnect: qcom: Add SDX55 interconnect provider driver

From: kernel test robot
Date: Thu Jan 21 2021 - 07:59:49 EST


Hi Manivannan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.11-rc4 next-20210121]
[cannot apply to robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Manivannan-Sadhasivam/Add-interconnect-driver-for-SDX55/20210121-134627
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 45dfb8a5659ad286c28fa59008271dbc4e5e3f2d
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c4a7f05ec335769c871c6f8abd85d5d6b866ed23
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Manivannan-Sadhasivam/Add-interconnect-driver-for-SDX55/20210121-134627
git checkout c4a7f05ec335769c871c6f8abd85d5d6b866ed23
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/interconnect/qcom/sdx55.c:114:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
114 | const static struct qcom_icc_desc sdx55_mc_virt = {
| ^~~~~
drivers/interconnect/qcom/sdx55.c:136:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
136 | const static struct qcom_icc_desc sdx55_mem_noc = {
| ^~~~~
drivers/interconnect/qcom/sdx55.c:215:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
215 | const static struct qcom_icc_desc sdx55_system_noc = {
| ^~~~~
drivers/interconnect/qcom/sdx55.c:231:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
231 | const static struct qcom_icc_desc sdx55_ipa_virt = {
| ^~~~~


vim +/static +114 drivers/interconnect/qcom/sdx55.c

113
> 114 const static struct qcom_icc_desc sdx55_mc_virt = {
115 .nodes = mc_virt_nodes,
116 .num_nodes = ARRAY_SIZE(mc_virt_nodes),
117 .bcms = mc_virt_bcms,
118 .num_bcms = ARRAY_SIZE(mc_virt_bcms),
119 };
120

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip