Re: [PATCH v1] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

[Marc Kleine-Budde]

On Thu, Jan 21, 2021 at 04:33:13PM +0800, Su Yanjun wrote:
> No functional effect.
> 
> Signed-off-by: Su Yanjun <suyanjun218@xxxxxxxxx>

Fails to build from source:

  CC [M]  drivers/net/can/spi/mcp251xfd/mcp251xfd-core.o
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: In function ‘mcp251xfd_get_val_bytes’:
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c:187:22: error: invalid use of undefined type ‘struct regmap’
  187 |  return priv->map_reg->format.val_bytes;
      |                      ^~
rivers/net/can/spi/mcp251xfd/mcp251xfd-core.c:188:1: error: control reaches end of non-void function [-Werror=return-type]
  188 | }
      | ^
cc1: some warnings being treated as errors

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature