RE: [PATCH] rtsx: pci: fix device aspm state bug

[吳昊澄 Ricky]

> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Thursday, January 21, 2021 3:46 PM
> To: 吳昊澄 Ricky <ricky_wu@xxxxxxxxxxx>
> Cc: arnd@xxxxxxxx; ricky_wu@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx;
> sashal@xxxxxxxxxx; levinale@xxxxxxxxxx; keitasuzuki.park@xxxxxxxxxxxxxxxxxxxx;
> kdlnx@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] rtsx: pci: fix device aspm state bug
> 
> On Thu, Jan 21, 2021 at 03:28:58PM +0800, ricky_wu@xxxxxxxxxxx wrote:
> > From: Ricky Wu <ricky_wu@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> >
> > changed rtsx_pci_disable_aspm() to rtsx_disable_aspm() make sure
> > pcr->aspm_enabled to sync with aspm state
> 
> Can you make this a bit more descriptive?
> 
Changed rtsx_pci_disable_aspm() to rtsx_disable_aspm() make sure
pcr->aspm_enabled to sync with aspm state.
rtsx_pci_disable_aspm() this function disable aspm by setting config space directly
did not change value of pcr->aspm_enabled so changed to use rtsx_disable_aspm().
Give initial value to pcr->aspm_enabled by reading config space setting at init_hw(). 

> 
> >
> > BUG=b:175338107
> > TEST=chromeos-kernel-5_4
> 
> What are these lines for?
> 
> >
> > Signed-off-by: Ricky Wu <ricky_wu@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> 
> This email does not match your From: address :(
> 
> > Change-Id: I4b146dcdaaf2f2a965381c32780b0b110d751258
> 
> Please use checkpatch.pl before sending patches to us :(
> 
> And why did you send this twice?
> 
> thanks,
> 
> greg k-h
> 
> ------Please consider the environment before printing this e-mail.