Re: [PATCH v2 1/5] csky: Remove custom asm/atomic.h implementation

From: Guo Ren
Date: Thu Jan 21 2021 - 02:13:51 EST


Hi Peter,

On Thu, Jan 7, 2021 at 7:19 PM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> On Sun, Dec 20, 2020 at 03:39:19PM +0000, guoren@xxxxxxxxxx wrote:
> > From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> >
> > Use generic atomic implementation based on cmpxchg. So remove csky
> > asm/atomic.h.
>
> Clarification would be good. Typically cmpxchg() loops perform
> sub-optimal on LL/SC architectures, due to the double loop construction.

Yes, you are right. But I still want to use comm cmpxchg instead of my
implementation. Maybe in the future, we'll optimize it back.

--
Best Regards
Guo Ren

ML: https://lore.kernel.org/linux-csky/