Re: [PATCH v3 05/10] certs: Replace K{U,G}IDT_INIT() with GLOBAL_ROOT_{U,G}ID

From: Jarkko Sakkinen
Date: Wed Jan 20 2021 - 22:21:36 EST


On Wed, Jan 20, 2021 at 12:17:28PM +0100, Mickaël Salaün wrote:
>
> On 20/01/2021 06:15, Jarkko Sakkinen wrote:
> > On Thu, Jan 14, 2021 at 04:19:04PM +0100, Mickaël Salaün wrote:
> >> From: Mickaël Salaün <mic@xxxxxxxxxxxxxxxxxxx>
> >>
> >> Align with the new macros and add appropriate include files.
> >>
> >> Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> >> Signed-off-by: Mickaël Salaün <mic@xxxxxxxxxxxxxxxxxxx>
> >> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> >
> > The commit message makes no sense. What you new macros?
>
> What about "Use the new GLOBAL_ROOT_UID and GLOBAL_ROOT_GID definitions,
> and add appropriate include files."?

They were added in 2011 so you could just remove "the new". Otherwise,
WFM.

/Jarkko