Re: [PATCH v4 8/8] mm: Mark anonymous struct field of 'struct vm_fault' as 'const'

From: Linus Torvalds
Date: Wed Jan 20 2021 - 14:05:20 EST


On Wed, Jan 20, 2021 at 10:27 AM Nick Desaulniers
<ndesaulniers@xxxxxxxxxx> wrote:
>
> Is there a difference between: [ const unnamed struct and individual const members ]

Semantically? No.

Syntactically the "group the const members together" is a lot cleaner,
imho. Not just from a "just a single const" standpoint, but from a
"code as documentation" standpoint.

But I guess to avoid the clang issue, we could do the "mark individual
fields" thing.

(It turns out that sparse gets this wrong too, so it's not just clang).

Linus