Re: [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range()

From: Peter Zijlstra
Date: Wed Jan 20 2021 - 12:48:45 EST


On Mon, Jan 11, 2021 at 05:10:46PM +0000, vincent.donnefort@xxxxxxx wrote:
> @@ -475,6 +478,11 @@ cpuhp_set_state(struct cpuhp_cpu_state *st, enum cpuhp_state target)
> static inline void
> cpuhp_reset_state(struct cpuhp_cpu_state *st, enum cpuhp_state prev_state)
> {
> + st->target = prev_state;
> +
> + if (st->rollback)
> + return;

I'm thinking that if we call rollback while already rollback we're hosed
something fierce, no?

That like going up, failing, going back down again, also failing, giving
up in a fiery death.