Re: [PATCH 2/2] interconnect: qcom: Add SDX55 interconnect provider driver

[Georgi Djakov]

Hi Mani,

On 1/20/21 18:37, Manivannan Sadhasivam wrote:
> Hi Georgi,
>
> On Wed, Jan 20, 2021 at 04:59:31PM +0200, Georgi Djakov wrote:
> > Hi Mani,
> >
> > Thanks for the patch!
> >
> > On 1/20/21 10:06, Manivannan Sadhasivam wrote:
> > > Add driver for the Qualcomm interconnect buses found in SDX55 based
> > > platforms. The topology consists of several NoCs that are controlled by
> > > a remote processor that collects the aggregated bandwidth for each
> > > master-slave pairs.
> > >
> > > Based on SM8250 driver and generated from downstream dts.
> > >
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > > ---
> > >    drivers/interconnect/qcom/Kconfig  |  10 +
> > >    drivers/interconnect/qcom/Makefile |   2 +
> > >    drivers/interconnect/qcom/sdx55.c  | 356 +++++++++++++++++++++++++++++
> > >    drivers/interconnect/qcom/sdx55.h  |  70 ++++++
> > >    4 files changed, 438 insertions(+)
> > >    create mode 100644 drivers/interconnect/qcom/sdx55.c
> > >    create mode 100644 drivers/interconnect/qcom/sdx55.h
> > >
> > > diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
> > > index a8f93ba265f8..6df7e2161a0a 100644
> > > --- a/drivers/interconnect/qcom/Kconfig
> > > +++ b/drivers/interconnect/qcom/Kconfig
> > > @@ -65,6 +65,16 @@ config INTERCONNECT_QCOM_SDM845
> > >    	  This is a driver for the Qualcomm Network-on-Chip on sdm845-based
> > >    	  platforms.
> > > +config INTERCONNECT_QCOM_SDX55
> > > +	tristate "Qualcomm SDX55 interconnect driver"
> > > +	depends on INTERCONNECT_QCOM
> > > +	depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST
> >
> > Why not use depends on INTERCONNECT_QCOM_RPMH_POSSIBLE?
>
> I just followed the same pattern as other RPMh based drivers. And I don't get
> what you are suggesting here! Can you please explain?

There are some recent changes here. Please check linux-next or v5.11-rc3+.

Thanks,
Georgi