Re: [PATCH v10 2/3] scsi: ufs: Refactor ufshcd_init/exit_clk_scaling/gating()

From: Stanley Chu
Date: Wed Jan 20 2021 - 00:13:01 EST


Hi Can,

On Tue, 2021-01-19 at 03:53 -0800, Can Guo wrote:
> ufshcd_hba_exit() is always called after ufshcd_exit_clk_scaling() and
> ufshcd_exit_clk_gating(), so move ufshcd_exit_clk_scaling/gating() to
> ufshcd_hba_exit(). Meanwhile, add dedicated funcs to init and remove
> sysfs nodes of clock scaling/gating to make the code more readable.
> Overall functionality remains same.
>
> Signed-off-by: Can Guo <cang@xxxxxxxxxxxxxx>

Looks good to me.

BTW, FYI. this series has conflicts during the merge to the latest
for-next branch in Martin's tree.

Reviewed-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx>