Re: [PATCH 1/2] s390: uv: Fix sysfs max number of VCPUs reporting

From: Cornelia Huck
Date: Tue Jan 19 2021 - 11:23:01 EST


On Tue, 19 Jan 2021 05:04:01 -0500
Janosch Frank <frankja@xxxxxxxxxxxxx> wrote:

> The number reported by the query is N-1 and I think people reading the
> sysfs file would expect N instead. For users creating VMs there's no
> actual difference because KVM's limit is currently below the UV's
> limit.
>
> The naming of the field is a bit misleading. Number in this context is
> used like ID and starts at 0. The query field denotes the maximum
> number that can be put into the VCPU number field in the "create
> secure CPU" UV call.
>
> Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
> Fixes: a0f60f8431999 ("s390/protvirt: Add sysfs firmware interface for Ultravisor information")
> Cc: stable@xxxxxxxxxxxxxxx
> ---
> arch/s390/boot/uv.c | 2 +-
> arch/s390/include/asm/uv.h | 4 ++--
> arch/s390/kernel/uv.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)

Acked-by: Cornelia Huck <cohuck@xxxxxxxxxx>