Re: [PATCH v3 05/21] x86/fpu/xstate: Add a new variable to indicate dynamic user states

[Borislav Petkov]

On Fri, Jan 15, 2021 at 07:47:38PM +0000, Bae, Chang Seok wrote:
> On Jan 15, 2021, at 05:39, Borislav Petkov <bp@xxxxxxx> wrote:
> > On Wed, Dec 23, 2020 at 07:57:01AM -0800, Chang S. Bae wrote:
> >> The perf has a buffer that is allocated on demand. The states saved in the
> > 
> > What's "the perf"? I hope to find out when I countinue reading…
> 
> Maybe it was better to write ‘Linux perf (tools)’ [1] here. Sorry for the
> confusion.

Well, I'm also confused as to what does the perf buffer have to do with
AMX?

> >> -#define XFEATURE_MASK_DYNAMIC (XFEATURE_MASK_LBR)
> >> +#define XFEATURE_MASK_SUPERVISOR_DYNAMIC (XFEATURE_MASK_LBR)
> > 
> > Is XFEATURE_MASK_USER_DYNAMIC coming too?
> 
> Instead of the new define, I thought the new variable --
> xfeatures_mask_user_dynamic, as its value needs to be determined at boot
> time.

Why isn't that in your commit message?

All I see a patch doing a bunch of renames, some unrelated blurb in the
commit message and I have no clue what's going on here and why you're
doing this. Your commit messages should contain simple english sentences
and explain *why* the change is needed - not *what* you're doing. The
*what* I can see from the diff itself, for the *why* I need a crystal
ball which I can't buy in any store.

So how about explaining the *why*?

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg