Re: [PATCH v2] driver core: Extend device_is_dependent()

From: Greg Kroah-Hartman
Date: Tue Jan 19 2021 - 10:27:26 EST


On Tue, Jan 19, 2021 at 04:09:14PM +0100, Rafael J. Wysocki wrote:
> On Fri, Jan 15, 2021 at 7:31 PM Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
> >
> > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> >
> > If the device passed as the target (second argument) to
> > device_is_dependent() is not completely registered (that is, it has
> > been initialized, but not added yet), but the parent pointer of it
> > is set, it may be missing from the list of the parent's children
> > and device_for_each_child() called by device_is_dependent() cannot
> > be relied on to catch that dependency.
> >
> > For this reason, modify device_is_dependent() to check the ancestors
> > of the target device by following its parent pointer in addition to
> > the device_for_each_child() walk.
> >
> > Fixes: 9ed9895370ae ("driver core: Functional dependencies tracking support")
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > Reported-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> > Tested-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
>
> Greg, are you going to pick up this one or do you want me to take care of it?
>
> It has been reviewed by Saravana.

I'll take it, thanks. sorry for the delay.

greg k-h