Re: [PATCH bpf] samples/bpf: Update README.rst and Makefile for manually compiling LLVM and clang

[Yonghong Song]

On 1/18/21 7:53 PM, Tiezhu Yang wrote:
> In the current samples/bpf/README.rst, the url of llvm and clang git
> may be out of date, they are unable to access:

Let us just rephrase the above more clearly, something like below.

The current clang/llvm build procedure in samples/bpf/README.rst is
out of date. See below that the links are not accessible any more.

> $ git clone http://llvm.org/git/llvm.git
> Cloning into 'llvm'...
> fatal: unable to access 'http://llvm.org/git/llvm.git/ ': Maximum (20) redirects followed
> $ git clone --depth 1 http://llvm.org/git/clang.git
> Cloning into 'clang'...
> fatal: unable to access 'http://llvm.org/git/clang.git/ ': Maximum (20) redirects followed

The llvm community has adopted new ways to build the compiler.
[followed by your descriptions below]

> There are different ways to build llvm/clang, I find the Clang Getting
> Started page [1] has one way, as Yonghong said, it is better to just
> copy the build procedure in Documentation/bpf/bpf_devel_QA.rst to keep
> consistent.
>
> I verified the procedure and it is proved to be feasible, so we should
> update README.rst to reflect the reality. At the same time, update the
> related comment in Makefile.
>
> [1] https://clang.llvm.org/get_started.html
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>

Ack with minor nits in the above. Also, this is a documentation update.
I think it is okay to target the patch to bpf-next instead of bpf.

Acked-by: Yonghong Song <yhs@xxxxxx>