Re: [PATCH v8 00/13] Add Broadcom VK driver

From: Olof Johansson
Date: Mon Jan 18 2021 - 18:07:21 EST


On Sun, Jan 17, 2021 at 11:17 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sun, Jan 17, 2021 at 10:47:59AM -0800, Olof Johansson wrote:
> > Hi,
> >
> > On Mon, Nov 30, 2020 at 10:42 AM Scott Branden
> > <scott.branden@xxxxxxxxxxxx> wrote:
> > >
> > > This patch series drops previous patches in [1]
> > > that were incorporated by Kees Cook into patch series
> > > "Introduce partial kernel_read_file() support" [2].
> > >
> > > Remaining patches are contained in this series to add Broadcom VK driver.
> > > (which depends on request_firmware_into_buf API addition which has
> > > now been accepted into the upstream kernel as of v5.10-rc1).
> > >
> > > [1] https://lore.kernel.org/lkml/20200706232309.12010-1-scott.branden@xxxxxxxxxxxx/
> > > [2] https://lore.kernel.org/lkml/20201002173828.2099543-1-keescook@xxxxxxxxxxxx/
> >
> >
> > I've been following this series for some time, and I think the code is
> > ready to go in.
> >
> > Greg, mind queuing this up in the misc tree?
>
> I will need a new version, this is long gone from my queue.

I'll let Scott repost then (with acks applied etc)

> And hopefully the tty layer abuse is gone... :)

There's a simple tty driver as the final patch in the series, but it's
pretty straightforward.

If you've still got concerns with it, the rest of the series should
stand on its own and should be mergeable without that piece.


-Olof