Re: [PATCH 0/2] net: dsa: mv88e6xxx: fix vlan filtering for 6250

From: Vladimir Oltean
Date: Sun Jan 17 2021 - 16:10:05 EST


Hi Rasmus,

On Sat, Jan 16, 2021 at 03:39:34AM +0100, Rasmus Villemoes wrote:
> I finally managed to figure out why enabling VLAN filtering on the
> 6250 broke all (ingressing) traffic,
> cf. https://lore.kernel.org/netdev/6424c14e-bd25-2a06-cf0b-f1a07f9a3604@xxxxxxxxx/
> .
>
> The first patch is the minimal fix and for net, while the second one
> is a little cleanup for net-next.
>
> Rasmus Villemoes (2):
> net: dsa: mv88e6xxx: also read STU state in mv88e6250_g1_vtu_getnext
> net: dsa: mv88e6xxx: use mv88e6185_g1_vtu_getnext() for the 6250

It's strange to put a patch for net and one for net-next in the same
series. Nobody will keep a note for you to apply the second patch after
net has been merged back into net-next. So if you want to keep the
two-patch approach, you'd have to send just the "net" patch now, and the
"net-next" patch later.
But is there any reason why you don't just apply the second patch to
"net"?