Re: [PATCH 2/2] spi: fix the divide by 0 error when calculating xfer waiting time

From: Mark Brown
Date: Wed Dec 30 2020 - 08:47:50 EST


On Wed, Dec 30, 2020 at 10:24:20AM +0800, Xu Yilun wrote:
> On Tue, Dec 29, 2020 at 01:13:08PM +0000, Mark Brown wrote:

> > Does this still apply with current code? There have been some fixes in
> > this area which I think should ensure that we don't turn the speed down
> > to 0 if the controller doesn't supply a limit IIRC.

> Yes, there is chance the speed is set to 0, some related code from 5.11-rc1

Please check the code in the SPI tree and -next.

> BTW, Could we keep the spi->max_speed_hz if no controller->max_speed_hz?
> Always clamp the spi->max_speed_hz to 0 makes no sense.

Right, that's the fix.

Attachment: signature.asc
Description: PGP signature