[PATCH 5.10 064/717] drm/edid: Fix uninitialized variable in drm_cvt_modes()

From: Greg Kroah-Hartman
Date: Mon Dec 28 2020 - 10:22:07 EST


From: Lyude Paul <lyude@xxxxxxxxxx>

[ Upstream commit 991fcb77f490390bcad89fa67d95763c58cdc04c ]

Noticed this when trying to compile with -Wall on a kernel fork. We
potentially don't set width here, which causes the compiler to complain
about width potentially being uninitialized in drm_cvt_modes(). So, let's
fix that.

Changes since v1:
* Don't emit an error as this code isn't reachable, just mark it as such
Changes since v2:
* Remove now unused variable

Fixes: 3f649ab728cd ("treewide: Remove uninitialized_var() usage")
Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx>
Reviewed-by: Ilia Mirkin <imirkin@xxxxxxxxxxxx>
Link: https://patchwork.freedesktop.org/patch/msgid/20201105235703.1328115-1-lyude@xxxxxxxxxx
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
---
drivers/gpu/drm/drm_edid.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 631125b46e04c..b84efd538a702 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -3114,6 +3114,8 @@ static int drm_cvt_modes(struct drm_connector *connector,
case 0x0c:
width = height * 15 / 9;
break;
+ default:
+ unreachable();
}

for (j = 1; j < 5; j++) {
--
2.27.0