Re: [PATCH v2 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators

From: Rob Herring
Date: Wed Dec 09 2020 - 09:02:53 EST


On Mon, Nov 30, 2020 at 04:11:38PM -0500, Jim Quinlan wrote:
> Quite similar to the regulator bindings found in "rockchip-pcie-host.txt",
> this allows optional regulators to be attached and controlled by the
> PCIe RC driver.
>
> Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx>
> ---
> .../devicetree/bindings/pci/brcm,stb-pcie.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 807694b4f41f..baacc3d7ec87 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -85,6 +85,18 @@ properties:
> minItems: 1
> maxItems: 3
>
> + vpcie12v-supply:
> + description: 12v regulator phandle for the endpoint device
> +
> + vpcie3v3-supply:
> + description: 3.3v regulator phandle for the endpoint device

12V and 3.3V are standard slot supplies, can you add them to
pci-bus.yaml. Then some day maybe we can have common slot handling code.

With that, here you just need:

vpcie3v3-supply: true

> +
> + vpcie1v8-supply:
> + description: 1.8v regulator phandle for the endpoint device
> +
> + vpcie0v9-supply:
> + description: 0.9v regulator phandle for the endpoint device

These are not standard. They go to a soldered down device or
non-standard connector? For the former, the device should really be
described in DT and the supplies added there.

Mini PCIe connector also has 1.5V supply.

Rob