Re: [patch 8/8] ntp: Consolidate the RTC update implementation

[Jason Gunthorpe]

On Sun, Dec 06, 2020 at 10:46:21PM +0100, Thomas Gleixner wrote:
>  /*
>   * If we have an externally synchronized Linux clock, then update RTC clock
>   * accordingly every ~11 minutes. Generally RTCs can only store second
> @@ -686,6 +621,10 @@ static bool sync_cmos_clock(void)
>   */
>  static void sync_hw_clock(struct work_struct *work)
>  {
> +	static unsigned long offset_nsec = NSEC_PER_SEC / 2;

A comment here explaining this is the default: because the platform is
assumed to use CMOS, and by the way, this whole thing is obsolete
don't use it, seems appropriate..

The time split is clearer if you think of it from a bus/datasheet
perspective, less clear if you try to measure the system directly, eg
from an alarm. But, I think this  has a better chance of some rtclib
driver authors to fill in the datasheet value at least.

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason