Re: [patch 6/8] ntp, rtc: Move rtc_set_ntp_time() to ntp code

From: Jason Gunthorpe
Date: Mon Dec 07 2020 - 16:00:52 EST


On Sun, Dec 06, 2020 at 10:46:19PM +0100, Thomas Gleixner wrote:
> rtc_set_ntp_time() is not really RTC functionality as the code is just a
> user of RTC. Move it into the NTP code which allows further cleanups.
>
> Requested-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
> drivers/rtc/Makefile | 1
> drivers/rtc/systohc.c | 61 ----------------------------------
> include/linux/rtc.h | 34 -------------------
> kernel/time/ntp.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++--
> 4 files changed, 85 insertions(+), 99 deletions(-)

Fair enough, it is asymmetric with how HCTOSYS works, but not a big
deal

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason