Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

From: Jean Pihet
Date: Mon Dec 07 2020 - 14:44:59 EST


Hi Andrew,

On Tue, Dec 1, 2020 at 9:45 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > Configure the host port of the switch to match the host interface
> > settings. This is useful when the switch is directly connected to the
> > host MAC interface.
>
> Why do you need this when no other board does? Why is your board
> special?
>
> As i said before, i'm guessing your board has back to back PHYs
> between the SoC and the switch and nobody else does. Is that the
> reason why? Without this, nothing is configuring the switch MAC to the
> results of the auto-neg between the two PHYs?

Yes that is the case. From here I see this patch is too specific to
our setup, and so cannot be considered for merging.

>
> Or am i completely wrong?
No, this is completely right. I will drop this patch then.

Thank you very much for reviewing and for the suggestions.

BR,
Jean

>
> Andrew
>