Re: [PATCH] PCI: dwc: exynos: add back MSI dependency

From: Arnd Bergmann
Date: Mon Dec 07 2020 - 09:50:09 EST


On Mon, Dec 7, 2020 at 3:23 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> On Fri, Dec 4, 2020 at 10:58 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> > index 020101b58155..e403bb2eeb4c 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP
> > config PCI_EXYNOS
> > tristate "Samsung Exynos PCIe controller"
> > depends on ARCH_EXYNOS || COMPILE_TEST
> > + depends on PCI && PCI_MSI_IRQ_DOMAIN
>
> PCI isn't needed here.

Ah right. I had copied this from PCIE_DW_PLAT_HOST, and
I'm fairly sure it used to be needed at some point in the past,
but the Kconfig file has been changed enough over time that
it clearly is not needed any more, as the entire menu depends on
PCI nowadays, i.e. you can no longer have an endpoint-only
configuration.

Arnd