Re: [PATCH v2 2/3] PCI: j721e: Get offset within "syscon" from "ti,syscon-pcie-ctrl" phandle arg

From: Rob Herring
Date: Mon Dec 07 2020 - 09:31:35 EST


On Fri, Dec 4, 2020 at 1:52 AM Kishon Vijay Abraham I <kishon@xxxxxx> wrote:
>
> Get "syscon" pcie_ctrl offset from the argument of "ti,syscon-pcie-ctrl"
> phandle. Previously a subnode to "syscon" node was added which has the
> exact memory mapped address of pcie_ctrl but now the offset of pcie_ctrl
> within "syscon" is now being passed as argument to "ti,syscon-pcie-ctrl"
> phandle.
>
> If the offset is not provided in "ti,syscon-pcie-ctrl", the
> full memory mapped address of pcie_ctrl is used in order to maintain old
> DT compatibility.
>
> This change is as discussed in [1]
>
> [1] -> http://lore.kernel.org/r/CAL_JsqKiUcO76bo1GoepWM1TusJWoty_BRy2hFSgtEVMqtrvvQ@xxxxxxxxxxxxxx
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> ---
> drivers/pci/controller/cadence/pci-j721e.c | 28 +++++++++++++++-------
> 1 file changed, 19 insertions(+), 9 deletions(-)

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>