Re: [PATCH v1] gpio: dwapb: mask/unmask IRQ when disable/enable it

[luojiaxing]

On 2020/12/6 23:02, Linus Walleij wrote:
> On Sat, Dec 5, 2020 at 11:15 PM Serge Semin <fancer.lancer@xxxxxxxxx> wrote:
>
> > Hmm, that sounds like a problem, but the explanation is a bit unclear
> > to me. AFAICS you are saying that the only callbacks which are
> > called during the IRQ request/release are the irq_enable(), right? If
> > so then the only reason why we haven't got a problem reported due to
> > that so far is that the IRQs actually unmasked by default.
> What we usually do in cases like that (and I have discussed this
> with tglx in the past I think) is to simply mask off all IRQs in probe().
> Then they will be unmasked when requested by drivers.


Yes, I agree. but in this case I mean that they will not unmasked when 
drivers request IRQ.

Drivers request IRQ will only call irq_enable(), so if we mask all IRQ 
in gpio-dwab.'s probe(),

no one will unmask the IRQ for drivers.


Thanks

Jiaxing


> See e.g. gpio-pl061 that has this line in probe():
> writeb(0, pl061->base + GPIOIE); /* disable irqs */
>
> Yours,
> Linus Walleij
>
> .