Re: [PATCH v4] phram: Allow the user to set the erase page size.

From: Miquel Raynal
Date: Mon Dec 07 2020 - 06:16:30 EST


On Mon, 2020-12-07 at 09:55:29 UTC, Guohua Zhong wrote:
> From: Patrick O'Grady <patrick@xxxxxxxxxxxxx>
>
> Permit the user to specify the erase page size as a parameter.
> This solves two problems:
>
> - phram can access images made by mkfs.jffs2. mkfs.jffs2 won't
> create images with erase sizes less than 8KiB; many architectures
> define PAGE_SIZE as 4KiB.
>
> - Allows more effective use of small capacity devices. JFFS2
> needs somewhere between 2 and 5 empty pages for garbage collection;
> and for an NVRAM part with only 32KiB of space, a smaller erase page
> allows much better utilization in applications where garbage collection
> is important.
>
> Signed-off-by: Patrick O'Grady <patrick@xxxxxxxxxxxxx>
> Reviewed-by: Joern Engel <joern@xxxxxxxxx>
> Link: https://lore.kernel.org/lkml/CAJ7m5OqYv_=JB9NhHsqBsa8YU0DFRoP7C+W10PY22wonAGJK=A@xxxxxxxxxxxxxx/
> [Guohua Zhong: fix token array index out of bounds and update patch for kernel master branch]
> Signed-off-by: Guohua Zhong <zhongguohua1@xxxxxxxxxx>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel