Re: [RESEND PATCH v6 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

[Srinivas Kandagatla]

On 05/12/2020 22:36, Linus Walleij wrote:
> On Wed, Dec 2, 2020 at 5:35 PM Srinivas Kandagatla
> <srinivas.kandagatla@xxxxxxxxxx> wrote:
>
> > Add initial pinctrl driver to support pin configuration for
> > LPASS (Low Power Audio SubSystem) LPI (Low Power Island) pinctrl
> > on SM8250.
>
> Patch applied!
>
> > +config PINCTRL_LPASS_LPI
> > +       tristate "Qualcomm Technologies Inc LPASS LPI pin controller driver"
> > +       depends on GPIOLIB
>
> I added:
>
>      select PINMUX
>      select PINCONF
>      select GENERIC_PINCONF
>
> When applying. You need these I think, your code is working because
> other drivers are selecting these for you, right? The build robot would
> hack this to pieces though.

Many thanks for doing this!

--srini

> Yours,
> Linus Walleij