Re: [PATCH v1 1/3] dt-bindings: input: atmel_mxt_ts: Document atmel,wakeup-method and wake-GPIO

[Dmitry Osipenko]

Hello Linus,

06.12.2020 18:13, Linus Walleij пишет:
> On Sat, Dec 5, 2020 at 6:34 AM Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
> 
>> Some Atmel touchscreen controllers have a WAKE line that needs to be
>> asserted low in order to wake up controller from a deep sleep. Document
>> the wakeup methods and the wake-GPIO properties.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> 
> Looks really useful!
> 
>> +  atmel,wakeup-method:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: |
>> +      The WAKE line is an active-low input that is used to wake up the touch
>> +      controller from deep-sleep mode before communication with the controller
>> +      could be started. This feature used to minimize current consumption
>> +      when the controller is in deep sleep mode.
>> +
>> +      The WAKE pin can be connected in one of the following ways:
>> +       1) left permanently low
>> +       2) connected to the I2C-compatible SCL pin
>> +       3) connected to a GPIO pin on the host
>> +    enum:
>> +      - 0 # ATMEL_MXT_WAKEUP_NONE
>> +      - 1 # ATMEL_MXT_WAKEUP_I2C_SCL
>> +      - 2 # ATMEL_MXT_WAKEUP_GPIO
> 
> So you can add:
> minimum: 0
> maximum: 2
> 
> I suppose?

The min/max ranges aren't needed for the enums because the min/max are
already implied.

I skimmed through a few yamls that use enums, just to be sure, nobody
sets the min/max for a enum.

I noticed that some bindings use "default: value" for enums, perhaps it
will be good to set default=0 for this property, I'll improve it in v3.

> With that:
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thank you for taking a look at the patch!