Re: [PATCH 11/20] ethernet: ucc_geth: fix use-after-free in ucc_geth_remove()

From: Jakub Kicinski
Date: Sat Dec 05 2020 - 15:50:52 EST


On Sat, 5 Dec 2020 20:17:34 +0100 Rasmus Villemoes wrote:
> - unregister_netdev(dev);
> - free_netdev(dev);
> ucc_geth_memclean(ugeth);
> if (of_phy_is_fixed_link(np))
> of_phy_deregister_fixed_link(np);
> of_node_put(ugeth->ug_info->tbi_node);
> of_node_put(ugeth->ug_info->phy_node);
> + unregister_netdev(dev);
> + free_netdev(dev);

Are you sure you want to move the unregister_netdev() as well as the
free?