Re: [PATCH] macintosh/adb-iop: Send correct poll command

From: Finn Thain
Date: Fri Dec 04 2020 - 22:12:50 EST


On Fri, 4 Dec 2020, Geert Uytterhoeven wrote:

> Hi Finn,
>
> On Fri, Nov 20, 2020 at 5:54 AM Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
> > The behaviour of the IOP firmware is not well documented but we do know
> > that IOP message reply data can be used to issue new ADB commands.
> > Use the message reply to better control autopoll behaviour by sending
> > a Talk Register 0 command after every ADB response, not unlike the
> > algorithm in the via-macii driver. This poll command is addressed to
> > that device which last received a Talk command (explicit or otherwise).
> >
> > Cc: Joshua Thompson <funaho@xxxxxxxxx>
> > Fixes: fa3b5a9929fc ("macintosh/adb-iop: Implement idle -> sending state transition")
>
> WARNING: Unknown commit id 'fa3b5a9929fc', maybe rebased or not pulled?
>
> 32226e817043?
>

Yes, that's the one. I accidentally gave a commit id from one of my
backport branches.

> > Tested-by: Stan Johnson <userm57@xxxxxxxxx>
> > Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
>
> Thanks, will queue in the m68k for-v5.11 branch.
>

Thanks.

> Gr{oetje,eeting}s,
>
> Geert
>
>