Re: [PATCH net] net: bridge: vlan: fix error return code in __vlan_add()

From: Jakub Kicinski
Date: Fri Dec 04 2020 - 18:43:52 EST


On Fri, 4 Dec 2020 12:47:07 +0200 Nikolay Aleksandrov wrote:
> On 04/12/2020 10:48, Zhang Changzhong wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: f8ed289fab84 ("bridge: vlan: use br_vlan_(get|put)_master to deal with refcounts")
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>
>
> Acked-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxx>

Applied, thanks!