Re: [PATCHv2] clocksource: dw_apb_timer_of: add error handling if no clock available

From: Dinh Nguyen
Date: Fri Dec 04 2020 - 17:41:01 EST




On 12/4/20 2:00 PM, Daniel Lezcano wrote:
On 04/12/2020 16:36, Dinh Nguyen wrote:
commit ("b0fc70ce1f02 arm64: berlin: Select DW_APB_TIMER_OF") added the
support for the dw_apb_timer into the arm64 defconfig. However, for some
platforms like the Intel Stratix10 and Agilex, the clock manager doesn't
get loaded until after the timer driver get loaded. Thus, the driver hits
the panic "No clock nor clock-frequency property for" because it cannot
properly get the clock.

This patch adds the error handling needed for the timer driver so that
the kernel can continue booting instead of just hitting the panic.

Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>

Did you have time to test the different combinations ?

I did test both versions and did not see any difference between the two. On both versions, the kernel was able to continue to boot after trying to probe the timer driver.

Dinh